simplemap
simplemap copied to clipboard
Type error when no location is set.
If the map field is passed an array with empty string, rather than floats or null values, BaseLocation.php throws a TypeError:
Cannot assign string to property ether\simplemap\models\BaseLocation::$lat of type ?float
Although it won't validate shouldnt the Map field be able to handle a value like this:
Bit of normalization in the map fields normalizeValue() method should cover it, happy to submit a RR if easier?
https://github.com/ethercreative/simplemap/blob/c1a9347914ca949888ab088ed710477ab4beb75c/src/fields/MapField.php#L246
Any thoughts on this one?