react-cursor-position icon indicating copy to clipboard operation
react-cursor-position copied to clipboard
verified publisher icon ethanselzer

Replace unsafe lifecycle

Open dan-lee opened this issue 6 years ago • 4 comments

This is to fix the following warning and to be compatible with concurrent mode:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

It shouldn't affect the functionality, but I didn't test it. I converted some other components in the similar manner and it always worked out.

dan-lee avatar Nov 09 '19 15:11 dan-lee

Coverage Status

Coverage remained the same at 100.0% when pulling 746df2ba15a3d6cc27f0fbdd4e6e20c9e01e9bb9 on dan-lee:patch-1 into 0f594bb6f08e774c68ef131d883ece1a55823ad0 on ethanselzer:master.

coveralls avatar Nov 09 '19 15:11 coveralls

@ethanselzer Any chance getting this in soon? ✌️

dan-lee avatar Apr 03 '20 18:04 dan-lee

Can we get this merged and released? It's been ready for over a year.

geoguide avatar Nov 12 '20 19:11 geoguide

@geoguide Btw. there's always the option to use patch-package, which is my go-to tool to deal with situations like this.

dan-lee avatar Nov 18 '20 19:11 dan-lee