phabulous
phabulous copied to clipboard
Partial (?) fix for mainline issue 26 - routing maniphest tasks with …
…multiple projects
Codecov Report
Merging #61 into master will decrease coverage by
0.06%. The diff coverage is0%.
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 18.65% 18.59% -0.07%
==========================================
Files 23 23
Lines 820 823 +3
==========================================
Hits 153 153
- Misses 666 669 +3
Partials 1 1
| Impacted Files | Coverage Δ | |
|---|---|---|
| app/controllers/feed.go | 11.94% <0%> (-0.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bef1f2d...ce23c14. Read the comment docs.
@blades is this PR still relevant? If so can you please check the code formatting and style? And rebase on the latest master?
Thanks!
Unless you've fixed it yourself, then it probably is, yes. I'm unlikely to have the time in the near future to take a look due to stuff going on irl, but if you can wait a while I'll see what i can do. I'm not a go coder, though, so don't really have a clue about formatting/style in go :/
On 27 February 2018 12:55:58 pm Martin Schenck [email protected] wrote:
@blades is this PR still relevant? If so can you please check the code formatting and style? And rebase on the latest
master? Thanks!-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/etcinit/phabulous/pull/61#issuecomment-368864416
i've merged with your recent changes now; no conflicts apparently so that would imply you've not done any work in the affected area.
OK, thank you. I need more time to dig into this. But you are not forgotten!