jetcd icon indicating copy to clipboard operation
jetcd copied to clipboard

Add param of withBindVolumn for EtcdClusterExtension

Open liangyuanpeng opened this issue 3 years ago • 2 comments

I use remote docker for testcontainer to run unit test and i just got the error:

Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"invalid volume specification: 'C:\\Users\\Administrator\\AppData\\Local\\Temp\\jetcd_test_etcd0_8631704060335352785:/data.etcd:rw,z'"}

So i add param of bindVolumn for this case that do not need volumn.

liangyuanpeng avatar Sep 17 '22 09:09 liangyuanpeng

It would be nice to understand why the volume mount fails, ideally this should not be something you should be able to disable as it may be required by the jetcd container

lburgazzoli avatar Sep 18 '22 09:09 lburgazzoli

It would be nice to understand why the volume mount fails,

Run unit test on windows, and use remote docker container from linux, the voulme is C:\\Users\\Administrator\\xxx:/data.etcd:rw,z, this format can not use by docker container. So just got the error when container start.

ideally this should not be something you should be able to disable as it may be required by the jetcd container

Absolutely right, so still create volum for etcd test container by default, User need to use withBindVolumn(false) for disable volumn when they want to this.

liangyuanpeng avatar Sep 25 '22 13:09 liangyuanpeng

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 25 '22 00:11 github-actions[bot]

@liangyuanpeng can you fix the findings ?

lburgazzoli avatar Nov 25 '22 06:11 lburgazzoli

@lburgazzoli is this PR up to date?

I opened a #1123, I guess they are almost identical.

I have all code formatter + tests there. This feature is very important to me.

Thanks!

IlyasYOY avatar Jan 29 '23 17:01 IlyasYOY

@lburgazzoli is this PR up to date?

I opened a #1123, I guess they are almost identical.

I have all code formatter + tests there. This feature is very important to me.

Thanks!

Merged, THX !

lburgazzoli avatar Jan 30 '23 06:01 lburgazzoli

Done in https://github.com/etcd-io/jetcd/pull/1123

lburgazzoli avatar Jan 30 '23 06:01 lburgazzoli