client/pkg: fix revive unexported-return issue

[carsontham]

trafficstars

Fixes part of #18370

This PR updates the client/pkg to fix unexported-return linter issue.

In this pull request, I introduced a UnsafeSet interface that contains the original Set interface, along with a method ContainsAll(). This was to avoid making changes to this unsafeSet unit-test here.

The changes are:

• NewUnsafeSet() now returns an UnsafeSet interface, instead of *unsafeSet struct
• NewThreadsafeSet now returns a Set interface, instead of *tsafeSet struct

[k8s-ci-robot]

Hi @carsontham. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jmhbnz]

/ok-to-test

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 69.14%. Comparing base (c2cac61) to head (4b6844c). :warning: Report is 170 commits behind head on main.

Additional details and impacted files

see 39 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19913      +/-   ##
==========================================
- Coverage   70.14%   69.14%   -1.01%     
==========================================
  Files         399      415      +16     
  Lines       34099    34677     +578     
==========================================
+ Hits        23920    23978      +58     
- Misses       8792     9308     +516     
- Partials     1387     1391       +4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2cac61...4b6844c. Read the comment docs.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[carsontham]

hi @jmhbnz, I linked the flaky test triggered in this PR to one of the existing open issues as per the etcd contribution guide. could we rerun the test for this PR? thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carsontham, ivanvc Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@carsontham: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci-etcd-robustness-release36-amd64	5c2b96e8961f049875c17f8623852ef658d1292f	link	true	/test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[siyuanfoundation]

@ahrtr Can you review again? Thanks!