etcd
etcd copied to clipboard
grpcproxy: add support for WatchRequest_ProgressRequest
Fixes #19710
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alexandrevilain Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @alexandrevilain. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
Codecov Report
:x: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 69.32%. Comparing base (edfcadc) to head (4dfd84d).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| server/proxy/grpcproxy/watch.go | 61.53% | 3 Missing and 2 partials :warning: |
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/proxy/grpcproxy/watcher.go | 92.15% <100.00%> (+0.32%) |
:arrow_up: |
| server/proxy/grpcproxy/watch.go | 90.72% <61.53%> (-7.07%) |
:arrow_down: |
... and 25 files with indirect coverage changes
@@ Coverage Diff @@
## main #19711 +/- ##
==========================================
+ Coverage 69.25% 69.32% +0.06%
==========================================
Files 422 422
Lines 34819 34834 +15
==========================================
+ Hits 24115 24148 +33
+ Misses 9314 9299 -15
+ Partials 1390 1387 -3
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update edfcadc...4dfd84d. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/retest
/retest
Hi! Can someone please re-review the new implementation ? Thanks :)
@serathius Is there something I can do to get this PR merged ? Thanks :)
@alexandrevilain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci-etcd-robustness-release36-amd64 | 63e4f0bacdf9f202835634c3406aebe9c45321e1 | link | true | /test ci-etcd-robustness-release36-amd64 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/retest-required