etcd
etcd copied to clipboard
fix: enable thelper linter in client directory
Hi @mmorel-35. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.83%. Comparing base (
6779a89) to head (30f4e57). Report is 2 commits behind head on main.
:exclamation: Current head 30f4e57 differs from pull request most recent head 97c8869
Please upload reports for the commit 97c8869 to get more accurate results.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/expect/expect.go | 79.12% <100.00%> (ø) |
... and 28 files with indirect coverage changes
@@ Coverage Diff @@
## main #18746 +/- ##
==========================================
+ Coverage 68.78% 68.83% +0.04%
==========================================
Files 420 420
Lines 35481 35485 +4
==========================================
+ Hits 24407 24425 +18
+ Misses 9647 9633 -14
Partials 1427 1427
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6779a89...97c8869. Read the comment docs.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, mmorel-35
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ahrtr,jmhbnz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment