etcd
etcd copied to clipboard
etcd-io
e2e test reverse proxy unused functions cleanup
Part of the patches to fix https://github.com/etcd-io/etcd/issues/17737.
This PR aims to simplify the review load of https://github.com/etcd-io/etcd/pull/18641, by separating all the code cleanup parts first.
During the development of https://github.com/etcd-io/etcd/pull/17938, we agreed that during the transition to an L7 forward proxy, unused features and features targeting the L4 reverse proxy will be dropped.
The functions dropped are
- PauseAccept
- DelayAccept
- LatencyAccept
- PauseTX and PauseRX
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: henrybear327 Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.76%. Comparing base (
c86c93c) to head (345bdd4). Report is 697 commits behind head on main.
:exclamation: Current head 345bdd4 differs from pull request most recent head 5fb0352
Please upload reports for the commit 5fb0352 to get more accurate results.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/proxy/server.go | 62.13% <ø> (+1.18%) |
:arrow_up: |
... and 19 files with indirect coverage changes
@@ Coverage Diff @@
## main #18640 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.01%
==========================================
Files 420 420
Lines 35535 35395 -140
==========================================
- Hits 24438 24341 -97
+ Misses 9668 9618 -50
- Partials 1429 1436 +7
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c86c93c...5fb0352. Read the comment docs.
As mentioned in above comment, instead of gutting L4 proxy to make it L7 proxy can you instead fork it?
As mentioned in above comment, instead of gutting L4 proxy to make it L7 proxy can you instead fork it?
May I clarify what you mean by "fork it"? Do you mean that we maintain both L4 and L7 proxies in the codebase? :)
Thanks @henrybear327 for the cleanup. We created so many unused API/methods!
The only concern is that they are exported API/Methods, it means that they may be used by other applications (which is unlikely in practice?).
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.