etcd icon indicating copy to clipboard operation
etcd copied to clipboard

testutils: add ExpectExactNTimes function to LogObserver

Open clement2026 opened this issue 1 year ago • 4 comments

Context https://github.com/etcd-io/etcd/pull/18635#discussion_r1775086281

#18635 needs this.

clement2026 avatar Sep 25 '24 16:09 clement2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clement2026 Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 25 '24 16:09 k8s-ci-robot

Hi @clement2026. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 25 '24 16:09 k8s-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.81%. Comparing base (5704c61) to head (136409c). :warning: Report is 1668 commits behind head on main.

:warning: Current head 136409c differs from pull request most recent head 5b38a8f

Please upload reports for the commit 5b38a8f to get more accurate results.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18637      +/-   ##
==========================================
+ Coverage   68.77%   68.81%   +0.03%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
+ Hits        24439    24452      +13     
+ Misses       9666     9651      -15     
- Partials     1430     1432       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5704c61...5b38a8f. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 25 '24 16:09 codecov-commenter

Do we really need to check if compacted Raft log occured at most N times? This is hard to check, why checking if "compact-index": X is not enough ?

serathius avatar Sep 26 '24 07:09 serathius

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 08 '24 04:11 k8s-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 05:04 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 20 '25 00:07 github-actions[bot]