use uint64 for priority variable

[piggito]

trafficstars

Changing priority variable from uint16 to uint64 allows for a wider range of values. For instance, we have a use case where we need unix timestamp in nanoseconds granularity which is not supported by uint16 but requires uint64.

[k8s-ci-robot]

Hi @piggito. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivanvc]

Hi @piggito, thanks for your pull request. Unfortunately, this change would break the public API. I think you will have better odds at merging if you add a new function, EnqueueUint64() instead (along with its tests).

[piggito]

hi @ivanvc thank you for your feedback, I updated PR with new EnqueueUint64() function

[jmhbnz]

/ok-to-test

[codecov-commenter]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.75%. Comparing base (0167cb3) to head (749efe8). :warning: Report is 889 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
client/v3/experimental/recipes/priority_queue.go	70.58% <100.00%> (+3.92%)	:arrow_up:

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18557      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.01%     
==========================================
  Files         424      424              
  Lines       35764    35768       +4     
==========================================
+ Hits        24592    24594       +2     
- Misses       9748     9750       +2     
  Partials     1424     1424              

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0167cb3...749efe8. Read the comment docs.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[mickymiek]

Hi, is there something blocking this from getting merged?

[jmhbnz]

Hi, is there something blocking this from getting merged?

@piggito can you please rebase this pr and then review test output, thanks 🙏🏻

[piggito]

@jmhbnz I rebased and fixed tests, please can you review.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc, piggito Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@piggito: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci-etcd-robustness-release36-amd64	749efe80c6b398a071ce1b83ea197858e17879e0	link	true	/test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.