etcd icon indicating copy to clipboard operation
etcd copied to clipboard

benchmark: support InsecureSkipVerify

Open qsyqian opened this issue 1 year ago • 4 comments

When reproducing #18509 , i found that benchmark doesn't support InsecureSkipVerify, so add it.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

qsyqian avatar Sep 05 '24 07:09 qsyqian

Hi @qsyqian. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 05 '24 07:09 k8s-ci-robot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.77%. Comparing base (4a11ca6) to head (a29e7b5).

:exclamation: Current head a29e7b5 differs from pull request most recent head 46cf1e6

Please upload reports for the commit 46cf1e6 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18545      +/-   ##
==========================================
+ Coverage   68.73%   68.77%   +0.03%     
==========================================
  Files         420      420              
  Lines       35470    35470              
==========================================
+ Hits        24381    24394      +13     
+ Misses       9668     9655      -13     
  Partials     1421     1421              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a11ca6...46cf1e6. Read the comment docs.

codecov-commenter avatar Sep 05 '24 07:09 codecov-commenter

/ok-to-test

ahrtr avatar Sep 06 '24 11:09 ahrtr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, qsyqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 08 '24 08:09 k8s-ci-robot