etcd
etcd copied to clipboard
compact: add log for keyCompactions when finished compaction
add more log for debug #18509 Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Hi @qsyqian. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.81%. Comparing base (
68e7122) to head (531fc3e). Report is 1634 commits behind head on main.
:exclamation: Current head 531fc3e differs from pull request most recent head 7fb484c
Please upload reports for the commit 7fb484c to get more accurate results.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/storage/mvcc/kvstore_compaction.go | 100.00% <100.00%> (ø) |
... and 20 files with indirect coverage changes
@@ Coverage Diff @@
## main #18516 +/- ##
==========================================
+ Coverage 68.77% 68.81% +0.03%
==========================================
Files 420 420
Lines 35535 35536 +1
==========================================
+ Hits 24440 24453 +13
+ Misses 9660 9654 -6
+ Partials 1435 1429 -6
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 68e7122...7fb484c. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/ok-to-test
@qsyqian please rebase this PR, which should be able to fix the govulncheck workflow failure.
/retest
@qsyqian please rebase this PR, which should be able to fix the
govulncheckworkflow failure.
@ahrtr Done. Sorry for the late response.
/test pull-etcd-integration-1-cpu-amd64
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahrtr, qsyqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ahrtr]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
@qsyqian: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci-etcd-robustness-release36-amd64 | 7fb484cd8aee0eef3a6c2b5118d36c05f619c207 | link | true | /test ci-etcd-robustness-release36-amd64 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.