etcd
etcd copied to clipboard
KEP-4578: make the featuragate test more extensible.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
part of https://github.com/etcd-io/etcd/issues/18023
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liangyuanpeng Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @liangyuanpeng. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
:x: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base (93a245a) to head (c518fd3).
:warning: Report is 2248 commits behind head on main.
:warning: Current head c518fd3 differs from pull request most recent head a2be729
Please upload reports for the commit a2be729 to get more accurate results.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| client/v3/kubernetes/client.go | 0.00% | 27 Missing :warning: |
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/storage/mvcc/kvstore.go | 89.76% <100.00%> (ø) |
|
| client/v3/kubernetes/client.go | 0.00% <0.00%> (ø) |
... and 21 files with indirect coverage changes
@@ Coverage Diff @@
## main #18508 +/- ##
==========================================
- Coverage 68.83% 68.82% -0.01%
==========================================
Files 420 420
Lines 35489 35470 -19
==========================================
- Hits 24429 24413 -16
+ Misses 9639 9628 -11
- Partials 1421 1429 +8
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 93a245a...a2be729. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.