etcd icon indicating copy to clipboard operation
etcd copied to clipboard

KEP-4578: make the featuragate test more extensible.

Open liangyuanpeng opened this issue 1 year ago • 3 comments

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

part of https://github.com/etcd-io/etcd/issues/18023

liangyuanpeng avatar Aug 27 '24 05:08 liangyuanpeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liangyuanpeng Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 27 '24 05:08 k8s-ci-robot

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 27 '24 05:08 k8s-ci-robot

Codecov Report

:x: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base (93a245a) to head (c518fd3). :warning: Report is 2248 commits behind head on main.

:warning: Current head c518fd3 differs from pull request most recent head a2be729

Please upload reports for the commit a2be729 to get more accurate results.

Files with missing lines Patch % Lines
client/v3/kubernetes/client.go 0.00% 27 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/kvstore.go 89.76% <100.00%> (ø)
client/v3/kubernetes/client.go 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18508      +/-   ##
==========================================
- Coverage   68.83%   68.82%   -0.01%     
==========================================
  Files         420      420              
  Lines       35489    35470      -19     
==========================================
- Hits        24429    24413      -16     
+ Misses       9639     9628      -11     
- Partials     1421     1429       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93a245a...a2be729. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Aug 27 '24 06:08 codecov-commenter

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 18 '24 06:12 k8s-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 05:04 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 23 '25 00:07 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 23 '25 00:09 github-actions[bot]