etcd
etcd copied to clipboard
build(deps): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools/mod
Bumps github.com/golangci/golangci-lint from 1.59.1 to 1.60.3.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
v1.60.3
golangci-lintis a free and open-source project built by volunteers.If you value it, consider supporting us, the maintainers and linter authors.
We appreciate it! :heart:
For key updates, see the changelog.
Changelog
- c2e095c022a97360f7fff5d49fbc11f273be929a build(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c83a0 (#4943)
- f0c190436343e51e6b4dc98a368cf7bae0e5f33a feat: check that Go version use to build is greater or equals to the Go version of the project (#4938)
v1.60.2
golangci-lintis a free and open-source project built by volunteers.If you value it, consider supporting us, the maintainers and linter authors.
We appreciate it! :heart:
For key updates, see the changelog.
Changelog
- f338f3ef33f0f7b641100aa1fd759549cc959a8b build(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91fbe (#4927)
- 132d81cb5a37a48b190b3fbb58eeb7fcc754f71a build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)
- 15529a9d74d8b6904d7da121c6f8c96e502c070c build(deps): bump honnef.co/go/tools from 0.5.0 to 0.5.1 (#4911)
- e24ef74f8f63de3d1a31834c2754f31b32e571c3 build(deps): bump mvdan.cc/gofumpt from 0.6.0 to 0.7.0 (#4922)
- 87dd8fe7552a8c8374ebde29db3bda8b28055962 exportloopref: deprecation (#4916)
- ca0b09e5e3891abef239b7c14459c6fba90e796e gosec: add G602 analyzer (#4906)
- adbdfdb288e939a175182b7a12b7555215ce98b2 staticcheck: propagate Go version (#4907)
v1.60.1
golangci-lintis a free and open-source project built by volunteers.If you value it, consider supporting us, the maintainers and linter authors.
We appreciate it! :heart:
For key updates, see the changelog.
Changelog
- 1147824c go1.23 support (#4836)
- 9eeb891c build(deps): bump golang.org/x/tools from 0.23.0 to 0.24.0 (#4898)
- 73bbf822 build(deps): bump github.com/polyfloyd/go-errorlint from 1.5.2 to 1.6.0 (#4899)
- a9ea7d32 unused: remove exported-is-used option
- 90664f6c build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (#4893)
- 78a738f7 unused: remove exported-is-used option (#4890)
- 5536bb5c build(deps): bump github.com/mgechev/revive from 1.3.7 to 1.3.9 (#4886)
- f903621d build(deps): bump github.com/gofrs/flock from 0.12.0 to 0.12.1 (#4889)
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
v1.60.3
- Updated linters
gosec: from 81cda2f91fbe to ab3f6c1c83a0 (fixG115false positives)- Misc.
- Check that the Go version use to build is greater or equals to the Go version of the project
v1.60.2
- Updated linters
gofmt: update to HEAD (go1.22)gofumpt: from 0.6.0 to 0.7.0gosec: fix G602 analyzergosec: from 5f0084eb01a9 to 81cda2f91fbe (addsG115,G405,G406,G506,G507)staticcheck: from 0.5.0 to 0.5.1staticcheck: propagate Go versionwrapcheck: from 2.8.3 to 2.9.0- ⚠️
exportloopref: deprecationv1.60.1
- Updated linters
errorlint: from 1.5.2 to 1.6.0exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)gocognit: from 1.1.2 to 1.1.3gomodguard: from 1.3.2 to 1.3.3govet(printf): report non-constant format, no argslll: advertise max line length instead of just reporting failurerevive: from 1.3.7 to 1.3.9 (new rule:comments-density)sloglint: from 0.7.1 to 0.7.2spancheck: from 0.6.1 to 0.6.2staticcheck: from 0.4.7 to 0.5.0tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)testifylint: from 1.3.1 to 1.4.3 (new options:formatter,suite-broken-parallel,suite-subtest-run)tparallel: from 0.3.1 to 0.3.2usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)wsl: from 4.2.1 to 4.4.1- ️⚠️
unused: removeexported-is-usedoption- Fixes
- SARIF: sanitize level property
- ️⚠️
typecheckissues should never be ignored- Documentation
- Add link on linter without configuration
- Remove 'trusted by' page
wslupdate documentation of the configuration- misc.
- 🎉 go1.23 support
v1.60.0
... (truncated)
Commits
c2e095cbuild(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c8...f0c1904feat: check that Go version use to build is greater or equals to the Go versi...2f53f2cdocs: update documentation (#4931)1bdd38bdocs: update documentation assets (#4930)561049ddocs: update GitHub Action assets (#4929)f338f3ebuild(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91...741df1fdev: fix GO_VERSION in post release workflow (#4926)87dd8feexportloopref: deprecation (#4916)af298e1chore: update gofmt (#4923)132d81cbuild(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dependabot[bot] Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @dependabot[bot]. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.85%. Comparing base (
4d42c0f) to head (2960333).
:exclamation: Current head 2960333 differs from pull request most recent head 69324d7
Please upload reports for the commit 69324d7 to get more accurate results.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
see 17 files with indirect coverage changes
@@ Coverage Diff @@
## main #18504 +/- ##
==========================================
- Coverage 68.87% 68.85% -0.02%
==========================================
Files 420 420
Lines 35489 35489
==========================================
- Hits 24444 24437 -7
- Misses 9617 9629 +12
+ Partials 1428 1423 -5
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4d42c0f...69324d7. Read the comment docs.
/ok-to-test
@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-etcd-verify | 69324d76a9b90de6807b79c297332587f7531cc2 | link | true | /test pull-etcd-verify |
| pull-etcd-integration-2-cpu-amd64 | 69324d76a9b90de6807b79c297332587f7531cc2 | link | true | /test pull-etcd-integration-2-cpu-amd64 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Could anyone resolve the workflow failures? Thanks
@henrybear327 @ArkaSaha30 @ivanvc
Could anyone resolve the workflow failures? Thanks
@henrybear327 @ArkaSaha30 @ivanvc
I am on it.
I am on it.
@henrybear327, you're doing it as part of the weekly dependency bump, right?
Before
➜ etcd git:(dependencies/08_29_24) grep -Ri "github.com/golangci/golangci-lint v" | grep -v sum
./tools/mod/go.mod: github.com/golangci/golangci-lint v1.59.1
After
➜ etcd git:(dependencies/08_29_24) ✗ grep -Ri "github.com/golangci/golangci-lint v" | grep -v sum
./tools/mod/go.mod: github.com/golangci/golangci-lint v1.60.3
Thanks, @henrybear327. Check https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18504/pull-etcd-verify/1828149502016491520. I think you'll need to address that along with the dependency bump (what Benjamin was referring to)
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18504/pull-etcd-verify/1828149502016491520
Oh, thanks @ivanvc for the pointer! I will put up the PR as a draft first, then I will start to address it! :)
Thanks, @henrybear327. Check https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18504/pull-etcd-verify/1828149502016491520. I think you'll need to address that along with the dependency bump (what Benjamin was referring to)
Addressed
Looks like github.com/golangci/golangci-lint is up-to-date now, so this is no longer needed.