KEP-4578: migrate experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag to feature gate.

[liangyuanpeng]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

part of https://github.com/etcd-io/etcd/issues/18023

When I opened this PR, I found that these two flags were not in the migration list of https://github.com/etcd-io/etcd/issues/18023.

/hold
for confirm whether need to continue with the PR to complete experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag migration.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liangyuanpeng Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (62e4433) to head (c71ba86). Report is 797 commits behind head on main.

:exclamation: Current head c71ba86 differs from pull request most recent head 0507c53

Please upload reports for the commit 0507c53 to get more accurate results.

Files with missing lines	Patch %	Lines
server/embed/config.go	50.00%	0 Missing and 1 partial :warning:
server/etcdserver/server.go	50.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/etcd.go	75.77% <ø> (-0.05%)	:arrow_down:
server/features/etcd_features.go	60.00% <ø> (ø)
server/embed/config.go	79.17% <50.00%> (-0.32%)	:arrow_down:
server/etcdserver/server.go	81.26% <50.00%> (-0.30%)	:arrow_down:

... and 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18479      +/-   ##
==========================================
- Coverage   68.79%   68.79%   -0.01%     
==========================================
  Files         420      420              
  Lines       35490    35489       -1     
==========================================
- Hits        24416    24413       -3     
+ Misses       9647     9646       -1     
- Partials     1427     1430       +3     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62e4433...0507c53. Read the comment docs.

[serathius]

/hold for confirm whether need to continue with the PR to complete experimental-enable-lease-checkpoint and experimental-enable-lease-checkpoint-persist flag migration.

I think we should graduate all --experimental. I can edit the top comment in https://github.com/etcd-io/etcd/issues/18023 and add them.

[ivanvc]

/ok-to-test

[k8s-ci-robot]

@liangyuanpeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-unit-test-386	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-unit-test-386
pull-etcd-unit-test-amd64	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-unit-test-amd64
pull-etcd-unit-test-arm64	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-unit-test-arm64
pull-etcd-integration-2-cpu-amd64	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-4-cpu-amd64	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-integration-4-cpu-amd64
pull-etcd-integration-1-cpu-amd64	0507c53db39304ccb47df0b1e925823a89333447	link	true	/test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[liangyuanpeng]

I think we should graduate all --experimental. I can edit the top comment in https://github.com/etcd-io/etcd/issues/18023 and add them.

Thanks for clear, I will continue this PR later.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ahrtr]

Can we resolve https://github.com/etcd-io/etcd/pull/18478#issuecomment-2306438528 firstly? Thanks

[siyuanfoundation]

@liangyuanpeng Are you still working on this?

[siyuanfoundation]

closing with replacement https://github.com/etcd-io/etcd/pull/19356