[main] Bump go toolchain to 1.23.1

[henrybear327]

Reference:

• https://github.com/etcd-io/etcd/issues/18443

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[henrybear327]

@ivanvc The devcontainer can't be updated now, because at the time of writing the 1.23 image hasn't been released yet.

Please see: https://hubgw.docker.com/r/microsoft/devcontainers-go

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.81%. Comparing base (5088131) to head (2d0982e).

:exclamation: Current head 2d0982e differs from pull request most recent head 29f3bc2

Please upload reports for the commit 29f3bc2 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18444      +/-   ##
==========================================
- Coverage   68.85%   68.81%   -0.04%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
- Hits        24425    24411      -14     
- Misses       9626     9639      +13     
- Partials     1423     1424       +1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5088131...29f3bc2. Read the comment docs.

[henrybear327]

@ivanvc I will resolve the CI error in the meantime. But we probably would be blocked by https://github.com/etcd-io/etcd/pull/18444#issuecomment-2289978906 in any case.

[ahrtr]

/test pull-etcd-govulncheck

[ahrtr]

For the pull-etcd-govulncheck failure, it should be caused the by environment. We might want to raise an issue to the kubernetes/test-infra

[jmhbnz]

Hey Team - The devcontainer is now available following https://github.com/devcontainers/images/pull/1167

[henrybear327]

For the pull-etcd-govulncheck failure, it should be caused the by environment. We might want to raise an issue to the kubernetes/test-infra

Hello @ahrtr,

Thanks for the idea and insight!

May I ask where exactly I should raise this issue?

Thank you!

[ivanvc]

May I ask where exactly I should raise this issue?

I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2.

[henrybear327]

May I ask where exactly I should raise this issue?

I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2.

Thanks @ivanvc for the hint.

I dug into the issue. As the k/k is still on 1.22, thus all the images are on 1.22 and not 1.23.

I am thinking of submitting a PR to add a new variant that contains 1.23, but not sure if this is the best way to do it.

@ivanvc do you have some ideas? I am happy to get involved in the prow / test-infra to get into this new field! :)

[ivanvc]

@henrybear327, if you have the time and know what to do, I'd say go for it. :)

[ivanvc]

@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks.

[henrybear327]

@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks.

Ok!

Should I bump others too?

[ivanvc]

Yes, if you want, please refer to #18548 (and assign it to you). I'm doing 3.4 and 3.5 because we want to expedite them for the releases.

[ivanvc]

/retitle [main] Bump go toolchain to 1.23.1

[henrybear327]

@ahrtr @ivanvc as we have discussed at https://github.com/etcd-io/etcd/issues/18548#issuecomment-2343061825 and offline, we will use 1.22.7 for the main branch now.

I will work on the test-infra image in the meantime and if I can get the 1.23.1 image working we can then upgrade the main branch to 1.23.1!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment