etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Fix passing default grpc call options in Kubernetes client

Open serathius opened this issue 1 year ago • 1 comments

Totally slipped past me, only found this because K8s has integration tests that expect client side grpc error for size of request. I didn't catch it as they are not located in apiserver package, but in controlplane. When iterating I assumed that all relevant tests are in apiserver package.

cc @ahrtr

serathius avatar Jul 24 '24 10:07 serathius

Codecov Report

:x: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.80%. Comparing base (fe796ab) to head (ff24c6b). :warning: Report is 2238 commits behind head on main.

:warning: Current head ff24c6b differs from pull request most recent head 2bcaed1

Please upload reports for the commit 2bcaed1 to get more accurate results.

Files with missing lines Patch % Lines
client/v3/kubernetes/client.go 0.00% 27 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
client/v3/kubernetes/client.go 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18360      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.03%     
==========================================
  Files         420      420              
  Lines       35489    35470      -19     
==========================================
- Hits        24407    24406       -1     
+ Misses       9650     9625      -25     
- Partials     1432     1439       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe796ab...2bcaed1. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Aug 29 '24 12:08 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 30 '24 13:08 k8s-ci-robot