etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Add SLSA provenance to your releases

Open udf2457 opened this issue 1 year ago • 7 comments
trafficstars

What would you like to be added?

Please add SLSA provenance to your releases.

It is easy to do on on Github:

https://github.com/slsa-framework/slsa-github-generator/blob/main/internal/builders/generic/README.md#provenance-for-goreleaser https://goreleaser.com/blog/slsa-generation-for-your-artifacts/#slsa-github-generator

Background info: https://docs.sigstore.dev/signing/overview/

Why is this needed?

Improving robustness against supply-chain attacks.

udf2457 avatar Apr 24 '24 17:04 udf2457

Contributions are welcomed

serathius avatar Apr 24 '24 18:04 serathius

Any further consideration given to moving to goreleaser @serathius as mentioned in #13980 ?

Adding provenance is a piece of cake with goreleaser.

I'm not sure why your present release.yml is why it is like it is ? Perhaps it predates goreleaser ? But tweaking your present release.yml to add provenance could be a time-consuming endeavour (at least for me, because I'm not familiar with the random shell scripts you are calling out to).

udf2457 avatar Apr 24 '24 20:04 udf2457

Up to date release instructions are in https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/release.md

serathius avatar Apr 25 '24 07:04 serathius

Github announced this yesterday, so will need to compare it to the process originally linked to see if it makes it more straightforward to implement.

udf2457 avatar May 03 '24 16:05 udf2457

Hello @serathius @udf2457 👋 I am interested to work on this issue

ArkaSaha30 avatar May 07 '24 09:05 ArkaSaha30

Hi @ArkaSaha30

I am currently focused on some high-priority $work projects, so your offer of assistance is much appreciated @ArkaSaha30 😉

Hopefully when things quiet down a little at $work I will be able to return to this !

udf2457 avatar May 07 '24 11:05 udf2457

Before jumping into coding, please start from reading the etcd release documentation to understand our current process and please propose what changes need to be made to provide SLSA provenance.

serathius avatar May 08 '24 07:05 serathius