etcd icon indicating copy to clipboard operation
etcd copied to clipboard

update CHANGELOG-3.5.md for #17447

Open halleyshx opened this issue 1 year ago • 5 comments

update CHANGELOG-3.5.md for https://github.com/etcd-io/etcd/pull/17447

halleyshx avatar Feb 19 '24 02:02 halleyshx

Hi @halleyshx. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 19 '24 02:02 k8s-ci-robot

Please rebase this PR and squash the commits.

ahrtr avatar Feb 19 '24 11:02 ahrtr

/retest

halleyshx avatar Feb 23 '24 06:02 halleyshx

Please rebase this PR and squash the commits.

We expect there is only one commit. THis PR has 4 commits

ahrtr avatar Feb 23 '24 09:02 ahrtr

Please rebase this PR firstly, the squash the 4 commits into one.

ahrtr avatar Feb 23 '24 09:02 ahrtr

Please rebase this PR firstly, the squash the 4 commits into one.

I did it, but I don't know why it didn't work. I would to make a new pr to make it work.

halleyshx avatar Feb 26 '24 01:02 halleyshx

@ahrtr Pls check https://github.com/etcd-io/etcd/pull/17488

halleyshx avatar Feb 26 '24 01:02 halleyshx