etcd icon indicating copy to clipboard operation
etcd copied to clipboard

build(deps): bump github.com/rivo/uniseg from 0.2.0 to 0.4.7

Open dependabot[bot] opened this issue 1 year ago • 5 comments

Bumps github.com/rivo/uniseg from 0.2.0 to 0.4.7.

Release notes

Sourced from github.com/rivo/uniseg's releases.

First feature-complete release

This release now contains:

  • Grapheme clustering
  • Word boundary detection
  • Sentence boundary detection
  • Line breaking / word wrapping
Commits
  • 03509a9 Fixed wrong width calculation for variation selectors combined with regular c...
  • 601bbb3 Clarified some performance statements.
  • f302f7f Clarifications and improvements in the package documentation.
  • 0b9a924 Improved performance by using switch statements instead of maps for state tra...
  • e258aa1 Switched from transition map to switch statement to improve performance.
  • b74d4dc Some performance improvements by fast-tracking property search on ASCII chara...
  • 97691fc Merge pull request #47 from junegunn/eastasian-ambiguous
  • 1f39ebc Add comment
  • 272e3f0 Allow configuring the width of East Asian ambiguous width characters
  • 3628fa1 Merge pull request #42 from meowgorithm/unicode-v15.0.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Feb 12 '24 17:02 dependabot[bot]

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 12 '24 17:02 k8s-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.90%. Comparing base (266a3ba) to head (46373e7).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17416      +/-   ##
==========================================
- Coverage   69.06%   68.90%   -0.17%     
==========================================
  Files         415      415              
  Lines       34951    34951              
==========================================
- Hits        24140    24082      -58     
- Misses       9426     9470      +44     
- Partials     1385     1399      +14     
Flag Coverage Δ
all 68.90% <ø> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 12 '24 18:02 codecov-commenter

github.com/rivo/uniseg is depended on by github.com/mattn/go-runewidth.

  • We need to bump the version of github.com/rivo/uniseg for github.com/mattn/go-runewidth firstly;
  • Bump the version of github.com/mattn/go-runewidth for github.com/cheggaaa/pb secondly.

cc @sharathSivakumar are you able to followup this? thx

$ go mod graph | grep github.com/rivo/uniseg
go.etcd.io/etcd/v3 github.com/rivo/[email protected]
github.com/cheggaaa/pb/[email protected] github.com/rivo/[email protected]
github.com/mattn/[email protected] github.com/rivo/[email protected]
go.etcd.io/etcd/etcdctl/[email protected] github.com/rivo/[email protected]
go.etcd.io/etcd/etcdutl/[email protected] github.com/rivo/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/rivo/[email protected]

ahrtr avatar Feb 13 '24 09:02 ahrtr

@ahrtr Will look into it today and make the necessary changes.

sharathsivakumar avatar Feb 13 '24 09:02 sharathsivakumar

/assign sharathsivakumar

ahrtr avatar Feb 13 '24 09:02 ahrtr

Should I take this one while working on this week's dependency updates?

ivanvc avatar Mar 11 '24 18:03 ivanvc

@ivanvc Yes please. I have been away for a while due to personal commitments. Please go ahead and bump it.

sharathsivakumar avatar Mar 11 '24 19:03 sharathsivakumar

@ahrtr do we want to bump github.com/rivo/uniseg and github.com/mattn/go-runewidth? These are indirect as github.com/cheggaaa/pb/v3 is already on its latest version v3.1.5.

ivanvc avatar Mar 11 '24 21:03 ivanvc

@ahrtr do we want to bump github.com/rivo/uniseg and github.com/mattn/go-runewidth?

Usually we don't bump an indirect dependency per indirect-dependencies unless there is a major CVE (>=7.5).

ahrtr avatar Mar 12 '24 07:03 ahrtr

Please feel free to close this PR if it's hard to push github.com/mattn/go-runewidth and github.com/cheggaaa/pb to bump the dependencies.

ahrtr avatar Mar 12 '24 07:03 ahrtr

I was asking because I didn't see any CVEs addressed in their release notes either. I already bumped it but didn't push the commit. I'll add it to #17576.

ivanvc avatar Mar 12 '24 15:03 ivanvc

Looks like github.com/rivo/uniseg is up-to-date now, so this is no longer needed.

dependabot[bot] avatar Mar 13 '24 09:03 dependabot[bot]