etcd icon indicating copy to clipboard operation
etcd copied to clipboard

chore: Enable lint var name.

Open liangyuanpeng opened this issue 1 year ago • 1 comments

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

liangyuanpeng avatar Jan 23 '24 07:01 liangyuanpeng

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 23 '24 07:01 k8s-ci-robot

Hi @liangyuanpeng, I see that you started working on addressing the warnings from this linter. However, the work required is rather large (I have addressed all of them, but after discussing this with the team on March 7th's community meeting, they decided to split addressing this into subtasks, which I'm already doing) and tracked in #17578.

However, would you be interested in working on enabling unexported-return?

ivanvc avatar Mar 13 '24 22:03 ivanvc

@ivanvc I'm not focusing on that right now, thank you for working on this and explain it.

liangyuanpeng avatar Mar 14 '24 06:03 liangyuanpeng