etcd icon indicating copy to clipboard operation
etcd copied to clipboard

[3.5] server: don't panic in readonly serializable txn

Open lavacat opened this issue 3 years ago • 1 comments
trafficstars

Problem: We pass grpc context down to applier in readonly serializable txn. This context can be cancelled for example due to timeout. This will trigger panic inside applyTxn

Solution: Only panic for transactions with write operations

fixes https://github.com/etcd-io/etcd/issues/14110 backported from main https://github.com/etcd-io/etcd/pull/14149

Signed-off-by: Bogdan Kanivets [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

lavacat avatar Jun 29 '22 08:06 lavacat

PR isn't merged yet, but even if solution changes, I think test is relevant

lavacat avatar Jun 29 '22 08:06 lavacat

Please update this PR per https://github.com/etcd-io/etcd/pull/14149

ahrtr avatar Aug 13 '22 21:08 ahrtr

Sorry about delay. Will update soon.

lavacat avatar Aug 30 '22 00:08 lavacat

@ahrtr @ptabor FYI, this is ready to merge

lavacat avatar Sep 13 '22 06:09 lavacat

This is just a backport PR, so merging...

Please add a changelog item if you haven't done it. @lavacat

ahrtr avatar Sep 13 '22 06:09 ahrtr