bbolt
bbolt copied to clipboard
etcd-io
Don't use MADV_RANDOM
In addition to the explicit documented behavior in posix_madvise(2) this call since Linux 6.4 also causes the kernel to aggressively free pages from the page cache by short circuiting the LRU second chance mechanism. The result is compaction events that took 900ms now take up to 20s and a system which generally operated with near zero major page faults sees 600 or more major faults per second during compaction events.
We've tested this change in older kernels and observed no negative impact in typical cloud instances.
Fixes https://github.com/etcd-io/bbolt/issues/939
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdodson Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @sdodson. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.