log4rs
log4rs copied to clipboard
Drop MSRV to 1.65 and bump toml, mock_instant
As toml has drop their MSRV to 1.65(https://github.com/toml-rs/toml/pull/730), we could cancel the version limit of toml and drop our MSRV to 1.65 too.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.76%. Comparing base (
8ab1b34) to head (0254d52). Report is 2 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 63.39% 63.76% +0.37%
==========================================
Files 24 25 +1
Lines 1557 1565 +8
==========================================
+ Hits 987 998 +11
+ Misses 570 567 -3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm good with dropping the toml limitation. However, is there implicit benefit to dropping the MSRV? On a separate thread a few months back, there had been talk of ~1 year MSRV support.
IMO, the lower MSRV is, the more user can use log4rs. As we dont need the new feature in higher version of MSRV now, I believe dropping MSRV has benefits. I remember our policy is at least 1 year MSRV, so it's ok to downgrade MSRV.
However, if you don't want to downgrade it, I'm also good about that and I can edit this PR. Thanks!
Good enough for me. The only "reason" I had to bump was once_cell is getting merged into std. But it's not new / needed functionality so not a priority.
https://github.com/estk/log4rs/issues/412
We now need 1.75 for derive_more, and i suspect 1.74 will become more and more common due to RPITIT and libs wanting to take advantage of that.