log4rs icon indicating copy to clipboard operation
log4rs copied to clipboard

Encode tests

Open gauntl3t12 opened this issue 1 year ago • 4 comments

Increase test coverage of the encode module.

Hard code the time string created by the json encoder for tests

gauntl3t12 avatar Mar 03 '24 02:03 gauntl3t12

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.88%. Comparing base (f688e38) to head (6dcf08c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   63.42%   64.88%   +1.46%     
==========================================
  Files          25       25              
  Lines        1572     1572              
==========================================
+ Hits          997     1020      +23     
+ Misses        575      552      -23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 03 '24 02:03 codecov-commenter

Now that once_cell is being pulled into the standard library in 1.70, we can bump to that and utilize the new standardized interface. Or, I can make similar modifications to the once_cell version to allow for dependency injection. @estk I'll defer to you on that decision. I know 1.70 is only 8 months old.

gauntl3t12 avatar Mar 03 '24 19:03 gauntl3t12

Ya lets stick to 1.69 for now

estk avatar Mar 03 '24 23:03 estk

@estk Swapped to OnceCell instead. I kept the version using the standard library in a separate branch that I'll submit towards the middle of the year when we look at moving up.

gauntl3t12 avatar Mar 04 '24 02:03 gauntl3t12