Steve Smith

Results 121 comments of Steve Smith

The distro may even work because it comes with its own dynamic libraries. Give it a try.

@reneeotten Note that PyTorch also has the Python dependency `cmake`: https://github.com/pytorch/pytorch/blob/a28bfb5ed545f00e6386519f3f92152001a19ddf/pyproject.toml#L9 I would just defer to upstream usage and consider merging and using #24096, rather than editing this out every...

> figure out why the build system decided that `cmake` is not installed whereas it clearly is there. FYSA: `cmake` in this context refers to the Python module of #24096,...

@reneeotten, @mascguy On macOS version prior to 14, there's this build error: ```sh CMAKE_LIBRARY_PATH='/opt/local/lib:/opt/local/lib/libomp' … LIBRARY_PATH='/opt/local/lib' … /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-pytorch/py312-pytorch/work/pytorch-2.3.0/build/CMakeFiles/FindOpenMP/OpenMPTryFlag.c:2:10: fatal error: 'omp.h' file not found #include ^~~~~~~ 1 error generated. ninja:...

@reneeotten I have successful builds on all macOS versions now. The CI errors are simply timeouts, and the logs show successful builds for many Python versions until the runner times...

@reneeotten This PR is ready to merge. I worked hard to ensure that it builds across all Python and CI versions. The remaining errors are simply CI timeouts because PyTorch...

Thanks for posting these issues. There’s several meta-issues that are relevant: 1. Indeed, the *nix instructions are years old and have not been updated, and neither has the Linux/rpm build...

Thank you Tiago. FWIW, I tried to update a while ago and ran into some build issue, and see there’s a CI error; I had attributed the issue I saw...

> @pmetzger Sorry, but this is outside of what I can do at the moment. This is not an upstream issue at all; as far as I can tell is...

@count0: Here's the `configure` error from `conf.log`: ```sh configure:22659: checking whether CGAL is available in /opt/local configure:22696: /opt/local/bin/clang++-mp-18 -o conftest -fopenmp -O3 -fvisibility=default -fvisibility-inlines-hidden -Wno-deprecated -Wall -Wextra -ftemplate-backtrace-limit=0 -pipe -I/opt/local/libexec/boost/1.81/include...