esp-idf icon indicating copy to clipboard operation
esp-idf copied to clipboard

fix(transport_ws): remove unnecessary noise from error message (IDFGH-14538)

Open erkia opened this issue 9 months ago • 4 comments
trafficstars

A message reporting an error about esp_transport_read() prints contents of the buffer that was passed to this function. The contents of this buffer are irrelevant in the context of this message.

  1. it can contain random, not NUL-terminated data from possibly partial read
  2. it can contain data from previous esp_transport_write() call that is using the same buffer.

In either case this is just a noise:

Screenshot_20250129_151900

erkia avatar Jan 29 '25 13:01 erkia

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 29 '25 13:01 CLAassistant

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello erkia, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against b1c3b69391ffb72463f48f596555f7abb9123269

github-actions[bot] avatar Jan 29 '25 13:01 github-actions[bot]

Hi @erkia thanks for the contribution. I'll follow with the process to merge.

euripedesrocha avatar Feb 18 '25 15:02 euripedesrocha

sha=b1c3b69391ffb72463f48f596555f7abb9123269

euripedesrocha avatar Feb 18 '25 15:02 euripedesrocha