esp-idf icon indicating copy to clipboard operation
esp-idf copied to clipboard

docs: Explain revocation of unused but compromised keys (IDFGH-13688)

Open Lupindakaas opened this issue 1 year ago • 6 comments

Description

This PR updates the Secure Boot V2 documentation to explain the revocation of unused but compromised keys.

Related

https://docs.espressif.com/projects/esp-idf/en/v5.2.2/esp32s3/security/secure-boot-v2.html#multiple-keys

Checklist

Before submitting a Pull Request, please ensure the following:

  • [ x] 🚨 This PR does not introduce breaking changes.
  • [ x] All CI checks (GH Actions) pass.
  • [ x] Documentation is updated as needed.
  • [x ] Tests are updated or added as necessary.
  • [ x] Code is well-commented, especially in complex areas.
  • [x ] Git history is clean — commits are squashed to the minimum necessary.

Lupindakaas avatar Sep 12 '24 14:09 Lupindakaas

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello Lupindakaas, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against 39d0eacde403051f8ecaa220f2cf4ca597c3f844

github-actions[bot] avatar Sep 12 '24 14:09 github-actions[bot]

@Lupindakaas Thanks for your quick revert. LGTM Can you please squash the commits into one?

AdityaHPatwardhan avatar Sep 17 '24 16:09 AdityaHPatwardhan

sha=b5f0e5c6af639d41bee0c970bae982967bca08e9

AdityaHPatwardhan avatar Sep 18 '24 13:09 AdityaHPatwardhan

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 19 '24 07:09 CLAassistant

@AdityaHPatwardhan Thanks for the review! I have (through many trials and trebulations) succesfully squashed the commits. Could you merge this PR? Have a nice day!

Lupindakaas avatar Sep 19 '24 07:09 Lupindakaas

sha=39d0eacde403051f8ecaa220f2cf4ca597c3f844

AdityaHPatwardhan avatar Sep 20 '24 03:09 AdityaHPatwardhan