feat(dhcp server): only hand out DNS if explicitly specified (IDFGH-13195)

[showier-drastic]

By default there isn't any dns server running on the ESP32, and it does not make sense to hand out DNS config here. On the other hand, handing out DNS config will affect the client machine if we don't want DNS traffic to go through ESP32, and there's no way to disable it. So only hand it out if explicitly enabled.

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

	Messages
:book:	🎉 Good Job! All checks are passing!

👋 Hello showier-drastic, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against c4e2274e058a82bf1ff9da29fe84cb66b1fc3442

[KisonHe]

Any update on this? I am also running into this problem. I plan to make my product communicate with PC using usb ncm. And I just find the dns server on esp is jamming net traffic on my client's PC.

By applying changes here the problem is then gone.

[abhik-roy85]

sha=c4e2274e058a82bf1ff9da29fe84cb66b1fc3442

[showier-drastic]

Hi @david-cermak , thanks for your reply!

This does break the captive portal example. How would you suggest adding a fix?

[david-cermak]

Hi @david-cermak , thanks for your reply!

This does break the captive portal example. How would you suggest adding a fix?

Thanks for checking. I suggest introducing a Kconfig option (enabled by default) which would keep the IP address as the DNS server, unless configured (current behaviour). If disabled, it would set the DNS option only if it's configured (behaviour after your change). We'll remove this Kconfig (altering the behavior) in IDF v6.0 (when we're allowed to make breaking changes).

PS: If you'd prefer, the ESP-IDF team can handle the backward compatibility changes on top of your commit. Let me know if you'd like us to take care of this!

[showier-drastic]

Hi @david-cermak , thanks for your reply! This does break the captive portal example. How would you suggest adding a fix?

Thanks for checking. I suggest introducing a Kconfig option (enabled by default) which would keep the IP address as the DNS server, unless configured (current behaviour). If disabled, it would set the DNS option only if it's configured (behaviour after your change). We'll remove this Kconfig (altering the behavior) in IDF v6.0 (when we're allowed to make breaking changes).

Understood, thanks for explanations!

PS: If you'd prefer, the ESP-IDF team can handle the backward compatibility changes on top of your commit. Let me know if you'd like us to take care of this!

Yes, that would be very nice.

[david-cermak]

Great, we've accepted your commit internally -- please wait while we handle the backward compatibility layer and merge it at once.

[tonyjackson-srt]

Great, we've accepted your commit internally -- please wait while we handle the backward compatibility layer and merge it at once.

@david-cermak, will this be back-ported to ESP-IDF v4.4.x?

[Alvin1Zhang]

Thanks for contribution again, changes have been merged with https://github.com/espressif/esp-idf/commit/649816d9a104796ea451b2d2b1c6bc4900ffb80d.