esp-idf icon indicating copy to clipboard operation
esp-idf copied to clipboard

ble_mesh: Fix OP_TIME_SET and OP_TIME_STATUS (IDFGH-12074)

Open s0be opened this issue 1 year ago • 4 comments

When a user app is handling these messages, the tai_utc_delta and time_zone_offset fields are not correctly populated. Resolve by properly setting the fields.

s0be avatar Feb 07 '24 23:02 s0be

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 07 '24 23:02 CLAassistant

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello s0be, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against 302c29719e1a3e3066dc5c13b92510df8405d577

github-actions[bot] avatar Feb 07 '24 23:02 github-actions[bot]

Anything I need to do to get this reviewed/merged?

s0be avatar Feb 28 '24 20:02 s0be

@forx157 We're still carrying this patch. It's obvious this is a bug, what do I need to do to get this merged?

s0be avatar Jul 29 '24 20:07 s0be

Hi, @s0be Sorry this has sat around for an extraordinary long time without further feedback. I've pushed this into our internal review & merge queue, PR will be updated once it's merged to master. Thanks again for your contribution!

forx157 avatar Aug 06 '24 07:08 forx157

Hi, @s0be Could update your commit info with the following format: fix(ble_mesh): your commit info

forx157 avatar Aug 06 '24 07:08 forx157

Thanks @forx157 I think I did it? I'm more familiar with PRs on gitlab than github.

s0be avatar Aug 07 '24 20:08 s0be

Hi, @s0be Thanks for that. I've pushed this into our internal review & merge queue, PR will be updated once it's merged to master.

forx157 avatar Aug 09 '24 03:08 forx157

Thanks for contribution again, changes have been merged with https://github.com/espressif/esp-idf/commit/3929afdb5fb574a2bd5960d5c42abaafc4d102d8.

Alvin1Zhang avatar Dec 06 '24 08:12 Alvin1Zhang