esp-idf-provisioning-android icon indicating copy to clipboard operation
esp-idf-provisioning-android copied to clipboard

Published 20 hours ago • verified publisher icon espressif

removing event bus + improving listeners

Open jashan1498 opened this issue 1 year ago • 5 comments

  • removing event bus library
  • cleaning up listener logic
  • updating app side logic after removing event bus

jashan1498 avatar Aug 23 '24 09:08 jashan1498

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 23 '24 09:08 CLAassistant

Hi @jashan1498 , Thanks for your contribution. We will check and update the code.

KhushbuShah25 avatar Aug 23 '24 17:08 KhushbuShah25

Hi @jashan1498 , Thanks for your contribution. We will check and update the code.

Hey @KhushbuShah25 @pedrominatel any update on this ? since its an urgent change that we need .. if there is some change required please let me know .. and can you also share the release timeline i.e when can we expect this to be merged and released

jashan1498 avatar Sep 10 '24 06:09 jashan1498

Hi @KhushbuShah25 ,

This PR would be a great enhancement for us as well. Can you provide an update about it please ?

RDrelec avatar Dec 16 '24 12:12 RDrelec

Hi @jashan1498,

Apologies for the delay. I was occupied with other tasks. I have checked changes and tested provisioning library and apps. Changes look good to me. But I found some issues while testing. Here are my observations :

  • Manual provisioning flow stopped working (mostly due to not getting event in manual provisioning screen).
  • Also existing onEvent method code runs on Main thread which needs to be taken care by some other way like executing onEvent method statements in runOnUiThread(). Because displaying alert dialog (popup) for any error is not working for disconnection or connection failure events.
  • Remove listener is missing when user presses back (onBackPressed()) , due to which whenever event occurs, app is receiving callback on older instance (previous screen instance which no longer exists) and it crashes.
  • The changes are not backward compatible and so, if existing customers update the library for some other reasons, they would also have to make changes in many screens (provisioning flow screens) , which we would want to avoid.

Could you please address the mentioned issues and update this PR accordingly?

KhushbuShah25 avatar Dec 24 '24 16:12 KhushbuShah25