esp-bsp icon indicating copy to clipboard operation
esp-bsp copied to clipboard

Published 20 hours ago • verified publisher icon espressif

ssd1680 support (BSP-643)

Open malachib opened this issue 9 months ago • 2 comments

ESP-BSP Pull Request checklist

  • [x] Version of modified component bumped
  • [ ] CI passing

Change description

Added row override so that ssd1680 may also be used

malachib avatar Feb 26 '25 22:02 malachib

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '25 22:02 CLAassistant

Thank you too for providing the ssd1681 in the first place!

I am open to your suggestion. I treated rows as precalculated as an optimization. Subtracts are about as fast as it gets though... Certainly the code is clearer the way you suggest.

malachib avatar Mar 04 '25 18:03 malachib

Hi @malachib and @tore-espressif , someone make more changes and new features in the PR https://github.com/espressif/esp-bsp/pull/612, do you agree to close this PR and continue in the new one?

espzav avatar Aug 04 '25 12:08 espzav

I agree. Somehow I never even knew you suggested those changes @tore-espressif , my apologies

malachib avatar Aug 04 '25 14:08 malachib