esp-bsp icon indicating copy to clipboard operation
esp-bsp copied to clipboard

fixes gt911 without reset pin (BSP-642)

Open AkaBkn opened this issue 9 months ago • 3 comments

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • [ ] Version of modified component bumped
  • [ ] CI passing

Change description

Please describe your change here

AkaBkn avatar Feb 26 '25 12:02 AkaBkn

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 26 '25 12:02 CLAassistant

I am not sure, if I understand right your changes. But this part of code needs both pins (interrupt + reset). This change is useless from my point of view.

espzav avatar Mar 18 '25 11:03 espzav

its not. without the patch, you can not use this driver without the reset pin (esp_lcd_touch_gt911->config.rst_gpio_num = GPIO_NUM_NC). but devices like the LilyGo T-Deck Plus have the reset pin not connected. with this change you can use the driver on those devices.

AkaBkn avatar Mar 19 '25 21:03 AkaBkn

its not. without the patch, you can not use this driver without the reset pin (esp_lcd_touch_gt911->config.rst_gpio_num = GPIO_NUM_NC). but devices like the LilyGo T-Deck Plus have the reset pin not connected. with this change you can use the driver on those devices.

Sorry for late reply. The code, which you changed, is only for setting I2C address of the controller during initialization. The reset is not necessary for other usage of this driver.

espzav avatar Apr 02 '25 08:04 espzav

@AkaBkn Please, did you see my latest comment?

espzav avatar Jun 18 '25 13:06 espzav

@AkaBkn Due to no activity and no issue found - closing this PR. Feel free reopen it.

espzav avatar Nov 20 '25 14:11 espzav