arduino-esp32 icon indicating copy to clipboard operation
arduino-esp32 copied to clipboard

add m5stack atom-s3u pindefs

Open mhaberler opened this issue 6 months ago • 9 comments

Description of Change

add M5Stack AromS3U pin definitions as per https://docs.m5stack.com/en/core/AtomS3U

mhaberler avatar May 11 '25 19:05 mhaberler

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 11 '25 19:05 CLAassistant

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello mhaberler, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against f499d99276ec0703db4d39fa9498b083efc2a3e8

github-actions[bot] avatar May 11 '25 19:05 github-actions[bot]

Hi @mhaberler, you are missing board definitions in boards.txt file. You need to add that also in order to be possible to select the board.

P-R-O-C-H-Y avatar May 12 '25 06:05 P-R-O-C-H-Y

Hi @mhaberler, you are missing board definitions in boards.txt file. You need to add that also in order to be possible to select the board.

thanks, will do

mhaberler avatar May 12 '25 07:05 mhaberler

Also please don't forget to sign the CLA

P-R-O-C-H-Y avatar May 12 '25 08:05 P-R-O-C-H-Y

Also please don't forget to sign the CLA

did that, succeeded, re-pushed with signed-off-by, CLA still looks unsigned in PR please advis

mhaberler avatar May 12 '25 11:05 mhaberler

well I dont know how to get past this CLA issue

I herewith certify I did sign the CLA for espressif/arduino-esp32 Version: 2023-04-20

Please go ahead and merge.

mhaberler avatar May 13 '25 12:05 mhaberler

well I dont know how to get past this CLA issue

I herewith certify I did sign the CLA for espressif/arduino-esp32 Version: 2023-04-20

Please go ahead and merge.

"Michael Haberler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account."

I see there are few commits that were committed with just a user name without an GitHub account. Can you please redo your changes (close/reopen the PR if needed) that all commits comes from your GH account @mhaberler. Thanks

P-R-O-C-H-Y avatar May 14 '25 06:05 P-R-O-C-H-Y

sorry about that. Will redo properly.

mhaberler avatar May 14 '25 11:05 mhaberler

@mhaberler Will you continue to work on this PR?

P-R-O-C-H-Y avatar Jun 30 '25 12:06 P-R-O-C-H-Y

sorry, was led astray and lack the energy for Arduino IDE for now so closing

mhaberler avatar Jun 30 '25 12:06 mhaberler