Arduino icon indicating copy to clipboard operation
Arduino copied to clipboard

Waveform: int/uint8_t inconsistency and implied stop PWM

Open dok-net opened this issue 4 years ago • 3 comments

@earlephilhower This is basically a cleanup, and I'm asking for you to review this, because it's your code. I'm head scratching about the weak-ref magic you performed, it looks convoluted, but appears to be the only working variant - albeit I am worried that enablePhaseLockedWaveform(); does not remove the PWM bits from the final BSP like it was with the previous config menu?

dok-net avatar Apr 29 '21 21:04 dok-net

@s-hadinger I am curious if you would be willing to spend some time on giving an opinion with regard to this PR and/or #8011 performing with LED strips. Real-life use cases are the most interesting, after all :-)

dok-net avatar Jun 19 '21 12:06 dok-net

Sorry I'm not familiar with this code. I'm afraid I can't help.

s-hadinger avatar Jun 20 '21 18:06 s-hadinger

@s-hadinger I am sorry, too, I was just going by things like https://github.com/esp8266/Arduino/pull/7231#issuecomment-616758135 and #7057 and all your much appreciated feedback to #7022

dok-net avatar Jun 20 '21 20:06 dok-net