rust icon indicating copy to clipboard operation
rust copied to clipboard

Merge into main branch rust-lang/rust?

Open luojia65 opened this issue 4 years ago • 8 comments
trafficstars

By now developers have to compile whole custom Rust toolchain to work with xtensa isa. Is there any possibility to merge xtensa instruction set support into main branch Rust? Then developers can install them easily by using rustup toolchain add command.

luojia65 avatar Oct 28 '21 03:10 luojia65

I don't think this can be done until the Xtensa backend is merged into upstream LLVM, but I could be wrong.

mcilloni avatar Oct 28 '21 05:10 mcilloni

@mcilloni is correct, Rust won't accept Xtensa support upstream without atleast an experimental backend in LLVM upstream.

With the riscv chips, we've already upstreamed everything we can.

MabezDev avatar Oct 28 '21 09:10 MabezDev

Where to check the status?

URLs that I'm missing:

  • LLVM xtensa branch
  • issue that describes the merge of xtensa into LLVM
  • issue that describes the merge of "LLVM xtensa" into Rust

stappersg avatar Apr 24 '22 19:04 stappersg

  • https://github.com/espressif/llvm-project
  • https://github.com/espressif/llvm-project/issues/4
  • This issue.

MabezDev avatar Apr 26 '22 09:04 MabezDev

espressif/llvm-project#4 implies that all of the repo's changes have been merged to upstream LLVM, although the PR hasn't been closed yet.

What are the next steps?

paulocsanz avatar Feb 12 '23 07:02 paulocsanz

We have indeed got the first patch set merged into LLVM, however that set of patches is not yet sufficient for a working Rust compiler. We will update the tracking issue with the next series of patches as soon as we post them for review. You can find the entire set of Xtensa patches here: https://github.com/espressif/llvm-project/pull/62.

igrr avatar Feb 12 '23 09:02 igrr

Hey guys, just wanted to ping this as it seems there is some new traction over at the tracking issue https://github.com/espressif/llvm-project/issues/4 seems this might be coming pretty close

noahbliss avatar Mar 01 '24 21:03 noahbliss

seems this might be coming pretty close

My understanding (somebody can correct me if I'm wrong) is that there are still a large number of patches which need to be merged into LLVM before full Xtensa support is realized. Once this is complete, it will take time for these changes to propagate into Rust as well.

jessebraham avatar Mar 01 '24 23:03 jessebraham