esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Make our nightly CI checks pass

Open jessebraham opened this issue 1 year ago • 4 comments
trafficstars

These have been failing for awhile now, thanks to #2351 this became much easier to resolve.

Largely the failures were just due to lifetime elision, some small doc-comment related lint errors as well.

I have allowed the static_mut_refs package-wide for some packages; we are aware of the use of statics, I don't intend to rewrite these for this PR. Can be addressed at some other time.

No changes here warrant a CHANGELOG.md entry IMO.

Successful run: https://github.com/jessebraham/esp-hal/actions/runs/11365052005

jessebraham avatar Oct 16 '24 12:10 jessebraham

I would be somewhat happier if we could fix the lifetime stuff separately after the refactors, but I don't mind rebasing PRs, so we can also just get it over with. Thanks!

We can merge in any order, I don't mind having to do some rebasing. This wasn't a ton of work, don't want to make your life too difficult. Just lemme know.

jessebraham avatar Oct 16 '24 12:10 jessebraham

Will hold off on merging this to avoid making other contributor's lives difficult for the time being. Will update when it's convenient to do so.

jessebraham avatar Oct 21 '24 07:10 jessebraham

I think we can move forward with this now.

bugadani avatar Oct 25 '24 10:10 bugadani

Maybe not for esp-wifi - whenever #2396 lands it should fix nightly warnings there - for other crates should be fine

bjoernQ avatar Oct 25 '24 12:10 bjoernQ

Successful run:
https://github.com/jessebraham/esp-hal/actions/runs/11627076339

jessebraham avatar Nov 01 '24 09:11 jessebraham