esp-hal icon indicating copy to clipboard operation
esp-hal copied to clipboard

Published 20 hours ago • verified publisher icon esp-rs

Many drivers are dependent on eh2 traits

Open MabezDev opened this issue 1 year ago • 1 comments

We already were aware of twai, see #1123, but upon switching to eh1 by default, I had to hack in this commit: https://github.com/esp-rs/esp-hal/pull/1313/commits/121dca7e2201ef59657a5f3bd476612aaecc80a1. All of these fixme's and now public functions exist because they were only usable via the eh02 traits.

They need fixing so that

  • They work without any eh feature
  • The new APIs are documentated

MabezDev avatar Mar 20 '24 16:03 MabezDev

(See original comment)

jessebraham avatar Mar 28 '24 14:03 jessebraham

@MabezDev is working on GPIO, I have opened PRs for the remaining peripherals.

jessebraham avatar Apr 03 '24 17:04 jessebraham

If we've missed anything please let me know but otherwise this appears to be complete.

Perhaps similar consideration needs to be made for embedded-hal and embedded-hal-async (plus maybe other packages), however that's outside the scope of this issue.

jessebraham avatar Apr 04 '24 14:04 jessebraham