embedded-svc
embedded-svc copied to clipboard
align FirmwareInfo with esp_app_desc_t field size.
This PR addresses the differences (some fields are too small, one field is too large) in field sizes described in issue https://github.com/esp-rs/esp-idf-svc/issues/204. It ensures, that the fields in FirmwareInfo are large enough to hold the fields defined in esp_app_desc_t. For details see the issue above.
embedded-svc is meant to be completely unaware of esp-idf, so I don't think we should be changing this struct to fit esp-idf's alignment needs unless there is another valid reason to do so. Instead, I think that esp-idf-svc should be handling the conversion from the esp-idf type, to the svc type.
If it turns out the embedded-svc struct is unfit for its purpose, we can change it. Thoughts @ivmarkov @zredshift?
embedded-svc is meant to be completely unaware of esp-idf, so I don't think we should be changing this struct to fit esp-idf's alignment needs unless there is another valid reason to do so. Instead, I think that esp-idf-svc should be handling the conversion from the esp-idf type, to the svc type.
If it turns out the embedded-svc struct is unfit for its purpose, we can change it. Thoughts @ivmarkov @zRedShift?
I agree. If there is some field in the embedded-svc struct which is too short, let's extend it, but 100% alignment is not what we are seeking out here.