iperf icon indicating copy to clipboard operation
iperf copied to clipboard

fix build with gcc-15

Open heitbaum opened this issue 1 year ago • 1 comments

PLEASE NOTE the following text from the iperf3 license. Submitting a pull request to the iperf3 repository constitutes "[making] Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or 3.1-STABLE) to which this pull request applies: master and 3.17.1

  • Issues fixed (if any): compile with gcc-15

  • Brief description of code changes (suitable for use as a commit message): update declarations to include types as required by gcc-15 and -std=c23

heitbaum avatar Dec 09 '24 10:12 heitbaum

Thanks for the PR, we'll take a look!

bmah888 avatar Feb 07 '25 22:02 bmah888

I can test it.

current master will fail with gcc 15 https://github.com/userdocs/iperf3-static-test/actions/runs/14755488675

This patch branch does not - https://github.com/userdocs/iperf3-static-test/actions/runs/14755738953/job/41423407651

userdocs avatar Apr 30 '25 13:04 userdocs

@bmah888

https://sources.debian.org/patches/iperf3/3.18-2/02-gcc15.patch/

userdocs avatar Apr 30 '25 14:04 userdocs

@bmah888

https://sources.debian.org/patches/iperf3/3.18-2/02-gcc15.patch/

Perfect, thanks the help @userdocs!

bmah888 avatar May 02 '25 17:05 bmah888

Just to confirm it built fine on master with gcc15

https://github.com/userdocs/iperf3-static-test/actions/runs/14802833500

userdocs avatar May 02 '25 21:05 userdocs

@userdocs Thanks for the confirmation!

bmah888 avatar May 02 '25 23:05 bmah888

Thanks for the PR @heitbaum , or should I call you Mr. Bump? :-)

heitbaum is fine :-) as the LE distro packing lead, the team thought Mr.Bump suited, so the emoji stuck :-)

heitbaum avatar May 03 '25 03:05 heitbaum