eslint.org icon indicating copy to clipboard operation
eslint.org copied to clipboard

docs: fix predefined configs example in FlatConfig announcement

Open vadimcoder opened this issue 1 year ago • 15 comments

Prerequisites checklist

What is the purpose of this pull request?

The purpose is to update the 2022 FlatConfig announcement according to the latest breaking changes because Google still shows this page in search results.

What changes did you make? (Give an overview)

Aligned the blogpost with the latest docs.

Related Issues

https://github.com/eslint/eslint/issues/17488

Is there anything you'd like reviewers to focus on?

have a good day

vadimcoder avatar May 27 '24 17:05 vadimcoder

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: amareshsm / name: Amaresh S M (710354c2e2e66f462672e6c8897c6cafaa04d307)
  • :white_check_mark: login: vadimcoder / name: Vadim (9f242d83403fb9de2c63feda4efe2d2e81707c69)

Hi @vadimcoder!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot[bot] avatar May 27 '24 17:05 eslint-github-bot[bot]

Deploy Preview for de-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/66ba1fc08c593a00084ada25
Deploy Preview https://deploy-preview-574--de-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for es-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/66ba1fbfadb2a6000801b7f4
Deploy Preview https://deploy-preview-574--es-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for ja-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/66ba1fc024d30d0008896a0a
Deploy Preview https://deploy-preview-574--ja-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for hi-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/66ba1fc025aa5b000830682d
Deploy Preview https://deploy-preview-574--hi-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for zh-hans-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/66ba1fc08bcfc80008cea199
Deploy Preview https://deploy-preview-574--zh-hans-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for pt-br-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/66ba1fc0a1dd6900084e9d33
Deploy Preview https://deploy-preview-574--pt-br-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for fr-eslint ready!

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/66ba1fc0e061d00008640d9d
Deploy Preview https://deploy-preview-574--fr-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
Latest commit 710354c2e2e66f462672e6c8897c6cafaa04d307
Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/66ba1fbf2e4fa70008970ae7
Deploy Preview https://deploy-preview-574--new-eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 27 '24 17:05 netlify[bot]

because Google still shows this page in search results.

If this is the case, it might be better to add a note to the start of this blog post with a link to the latest docs.

@nzakas what do you think?

mdjermanovic avatar May 27 '24 18:05 mdjermanovic

to add a note to the start of this blog post with a link to the latest docs

But the first link in the latest docs is the link to 2022 announcement (part 2) again:

To learn more about the flat config format, refer to this blog post.

Maybe it's worth replacing the link to Part 2 with the link to Part 1 because part 1 it's more philosophical and will remain relevant for a long time.

vadimcoder avatar May 27 '24 18:05 vadimcoder

I'm fine with updating the blog post so long as we add a note about the update, like we did at the end of this post:

https://eslint.org/blog/2023/01/eslint-2022-year-review/

Adding a link to the current docs is probably a good idea, as well.

nzakas avatar May 27 '24 20:05 nzakas

@vadimcoder all that's left here is just to add a note at the bottom that says this post was updated. Do you want to finish this up?

nzakas avatar Jul 15 '24 15:07 nzakas

@vadimcoder Are you still working on this?

amareshsm avatar Jul 30 '24 19:07 amareshsm

@vadimcoder all that's left here is just to add a note at the bottom that says this post was updated. Do you want to finish this up?

It has been pending for a long time. I have a note at the bottom and it is ready for review now.

amareshsm avatar Aug 12 '24 14:08 amareshsm