Microsoft icon indicating copy to clipboard operation
Microsoft copied to clipboard

Improve acronyms rule to match defined acronyms

Open politician opened this issue 3 years ago • 3 comments

The Microsoft guide says that acronyms shouldn't be used unless they are spelled out. However, the current Vale rule does not allow for this.

Actual behavior:

Screenshot 2022-06-23 at 13 38 12

Expected behavior:

Because personal access token is spelled out just before the use of the acronym, it should not fail.

politician avatar Jun 23 '22 06:06 politician

The current implementation expects the definition's case to match, for example,

You must use a Personal Access Token (PAT).

would yield no alert.

jdkato avatar Jun 24 '22 03:06 jdkato

You are right, I had actually tried it but it didn't work because my markdown formatter put it on the next line. I guess that's too much of an edge case to bother.

Screenshot 2022-06-24 at 11 13 04

politician avatar Jun 24 '22 04:06 politician

I just made sure that the parser could pick it up, it does and it even recognizes my next usage of PAT. Great!

Screenshot 2022-06-24 at 11 18 29

politician avatar Jun 24 '22 04:06 politician