otp icon indicating copy to clipboard operation
otp copied to clipboard

ct: Remove usage of deprecated ct_slave in tests

Open jchristgit opened this issue 8 months ago • 6 comments

These commits update the common_test test suite to:

  • Remove usage of the deprecated ct_slave and slave modules in tests (with the exception of the ct_slave tests itself, and some test_server tests for test_server:start_node)
  • Switch ct:pal to ct:log in most top-level test suites (except for ct_log_SUITE, which explicitly wants to test them), since the stdout of peer nodes won't be shown on the main test nodes & IMO make sense to contain to the HTML logs
  • Enable the cte_track event handler in tests for both local and GitHub-based runs

The second and third commit are of course a bit opinionated, so I'm happy to drop them (and possibly make peer log to our stdout) if wanted.

jchristgit avatar Mar 08 '25 18:03 jchristgit

CT Test Results

  2 files   57 suites   1h 11m 33s ⏱️ 450 tests 435 ✅ 15 💤 0 ❌ 484 runs  466 ✅ 18 💤 0 ❌

Results for commit 21c61094.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Mar 08 '25 18:03 github-actions[bot]

I tried configuring cte_track for common_test once or twice, never finished. thanks for making an attempt! There is some funny output in common_test test output requiring more attention but this could be tackled later.

u3s avatar Apr 02 '25 07:04 u3s

There is some funny output in common_test test output requiring more attention but this could be tackled later.

do you mean the .. sequence of numbers? I saw that too, maybe we could move that into a peer-ed test at some point so it's hushed.

jchristgit avatar Apr 02 '25 18:04 jchristgit

There is some funny output in common_test test output requiring more attention but this could be tackled later.

do you mean the .. sequence of numbers? I saw that too, maybe we could move that into a peer-ed test at some point so it's hushed.

I mean all leftovers, after changing pal->log and taking logger events out. IIRC, there used to be some printouts when slave node was started ... maybe gone already with peer used.

u3s avatar Apr 03 '25 09:04 u3s

IIRC, there used to be some printouts when slave node was started ... maybe gone already with peer used.

I think those are mostly gone with peer, yeah: https://github.com/erlang/otp/actions/runs/14226758185/job/39868469457

I can check this out with a closer look next week, but I think the proper fix for that is to just run the tests that test ct:pal in a peer node where the output is captured.

jchristgit avatar Apr 13 '25 19:04 jchristgit

Hi @u3s, I pushed a new commit that hushes most of the remaining tests. cth_pre_post_test_io_SUITE is still noisy, I haven't figured out how to quiet it down - the cth_ctrl module of the suite data calls to error_logger and for some reason that ends up on stdout despite that running in a peered node. Have a nice long weekend :-)

jchristgit avatar Apr 18 '25 08:04 jchristgit