otp icon indicating copy to clipboard operation
otp copied to clipboard

Test_server:ts_tc failed on line 1794

Open verbus opened this issue 1 year ago • 3 comments

=== Test case: otp_SUITE:call_to_size_1/1 (click for source code)

=== Config value:

[{xref_server,daily_xref},
 {watchdog,<0.243.0>},
 {tc_logfile,"/home/verbus/otp-OTP-27.0-rc1/release/tests/test_server/[email protected]_11.54.57/tests.system_test.otp_SUITE.cases.logs/run.2024-02-17_11.54.57/otp_suite.call_to_size_1.html"},
 {tc_group_properties,[]},
 {tc_group_path,[]},
 {data_dir,"/home/verbus/otp-OTP-27.0-rc1/release/tests/system_test/otp_SUITE_data/"},
 {priv_dir,"/home/verbus/otp-OTP-27.0-rc1/release/tests/test_server/[email protected]_11.54.57/tests.system_test.otp_SUITE.cases.logs/run.2024-02-17_11.54.57/log_private/"},
 {nodenames,[]}]

=== Current directory is "/home/verbus/otp-OTP-27.0-rc1/release/tests/test_server/[email protected]_11.54.57"

=== Started at 2024-02-17 11:55:00

These calls are not allowed:

megaco_codec_meas:detect_version/4 calls non-recommended erlang:size/1 megaco_codec_meas:do_measure/8 calls non-recommended erlang:size/1 megaco_codec_transform:em/5 calls non-recommended erlang:size/1

*** CT Error Notification 2024-02-17 11:55:00.553 ***🔗 test_server:ts_tc failed on line 1794 Reason: {test_case_failed,{3,calls_to,{erlang,size,1}}}

Full error description and stacktrace

=== Ended at 2024-02-17 11:55:00 === Location: [{test_server,ts_tc,1794}, {test_server,run_test_case_eval1,1303}, {test_server,run_test_case_eval,1235}] === === Reason: {test_case_failed,{3,calls_to,{erlang,size,1}}}

verbus avatar Feb 17 '24 18:02 verbus

I was able to replicate the above via running the smoke-test suite.

The spec for the smoke test / suite ($ERL_TOP/release/tests/system_test/otp_SUITE.erl) blacklists size_1 ... which is then called in the megaco test suite (ex: $ERL_TOP/lib/megaco/examples/meas/megaco_codec_meas.erl). Given how the tests are built, I had a hard time using git blame or similar to see if the changes since 26.2.2 meant the blacklist, test, or function is "wrong".

BinaryPaean avatar Feb 19 '24 07:02 BinaryPaean

If someone can say what the intent for rc-27 is; e.g. is the pre-deprecation of size_1 in the suite correct, or the megaco_codec_meas.erl lib should be updated, I can make a small PR for it.

BinaryPaean avatar Feb 25 '24 20:02 BinaryPaean

It seems that the issues in megaco has been fixed (as of Feb 20).

bmk avatar Feb 27 '24 14:02 bmk