otp
otp copied to clipboard
erlang
ct: Add dark mode support to coverage pages
When common test is tasked with generating coverage via -cover, invert the colours of the webpage when the user prefers a dark color scheme. Similar support was added to the other CT-generated pages in commit bbe14c9ff74d7f87d74622f7918e6a8d53963a4d.
Screenshots
CT Test Results
3 files 69 suites 1h 26m 41s :stopwatch: 574 tests 561 :white_check_mark: 13 :zzz: 0 :x: 615 runs 599 :white_check_mark: 16 :zzz: 0 :x:
Results for commit e54538fb.
:recycle: This comment has been updated with latest results.
To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.
See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.
Artifacts
// Erlang/OTP Github Action Bot
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
have you checked Edge browser? can you check it? my instance renders background as white (see screenshot below) ...
Sorry for the delay with getting back to you on my PRs, life has been very busy lately. I will try to test this with Edge and investigate this by next week. I hope you have an enjoyable Easter weekend :-)
Sorry for the delay with getting back to you on my PRs, life has been very busy lately. I will try to test this with Edge and investigate this by next week. I hope you have an enjoyable Easter weekend :-)
great thanks!
I rebased from master and reproduced the issue on Edge.
The issue seems to be that Edge needs to have an explicitly set background color to be able to rotate it. The new changes work for me on Firefox and Edge.
Whilst checking the PR I also noticed the individual coverage pages didn't include any dark theme, so I'm wondering whether I forgot to push something there. I've added a snippet I believe to work, but unfortunately after rebasing from main I now get a segfault when compiling, even after cleaning :( I think it's due to my (very wonky) setup right now, so I'm going to convert this to a draft and get back to you when I have access to my proper dev machine again.
rm -rf and a new clone was actually the solution - it works properly for me in both Firefox and Edge now, so this is ready for review after all :slightly_smiling_face:
@u3s I got an e-mail about a comment you made on the tools CSS but I think you deleted it, did the question solve itself or should I change something?
@u3s I got an e-mail about a comment you made on the tools CSS but I think you deleted it, did the question solve itself or should I change something?
no. I think I've made it to quickly and answered it to myself later. thanks for contributions! sorry for delays.