Erik Welch

Results 185 comments of Erik Welch

I updated the docs to explain this feature (I was waiting on #7404). This means this is implemented, tested, and documented (and we had discussed and generally liked this spelling...

This PR should now be much easier to review now that https://github.com/networkx/networkx/pull/7494 has been merged (thanks for that!) since both PRs renamed `nx-loopback` to `nx_loopback`.

> Looks good, maybe we should log the silent dropping of unknown *_kwargs. Thanks for the reviews! I have added a log message for backends that are not installed (or...

Yeah, if `.. automodule::` is used in the future for any of these, there is risk of having duplicate targets if the explicit target isn't removed. So, yes, adding `automodule`...

As discussed in the weekly dispatching meeting, `"fallback_to_nx"` _probably_ doesn't make sense (yet) as a user-facing configuration option, so I removed it from `nx.config`. It is meant to be used...

> Are we looking for `nx.config?` to return something nice? That's the main thing I was thinking, so something like: ```python class Config(dict): """Something nice; go look online for more."""...

I'd be fine using a regular `dict` (and eventually adding online docs) so we can avoid these issues for now. Performance-wise, I think subclassing from `dict` would be faster than...

I fixed the merge conflict, and I updated the name to `"backend_priority"`. Anything else?

I just created a `Config` class. It has a docstring that y'all should read. There are even tests (before you comment--yes, I do try to write tests, and it's nice...

The latest commit added the ability to define a subclass with `strict=False` to allow configs to be added and deleted. It works, but it does make things a little more...