Erik Welch

Results 185 comments of Erik Welch

No worries :) I was also traveling and mostly AFK last week. I will take a closer look at this PR. As for the error, it looks like you're running...

Hey, sorry for letting this sit. I was traveling and on vacation the last two weeks. I should have time to give this attention later this week.

I like it! I/we will definitely take a closer look. Thanks @alugowski It definitely looks more like a matrix, and I was thinking just the other day that pandas is...

Ooh, nested sub-matrix is pretty cool! Right now we just do what is easiest (hence using pandas in the first place). For submatrix dtypes, the easiest is to turn them...

Agreed 💯, they're very useful and should be in the online docs. Related issue https://github.com/python-graphblas/python-graphblas/issues/410, which also include a partial implementation. To explore the API of `python-graphblas`, using tab-completion in...

Huh. Good question. I have no idea what documentation that is referring to. @jim22k can you take a look? In general, we have `.ss` attributes on classes (`Matrix`, `Vector`), objects...

Just dropping in to say thank you for creating issues such as this one with specific suggestions for improving the documentation and overall user-experience--they're very helpful :)

I agree with this. For example, the API docs for Matrix, Vector, and Scalar should be on different pages instead of on one long page, right?

I agree it would be great to more thoroughly document the operators such as from `gb.binary`. We can/should probably even group them as "builtin, part of the spec", "builtin, SuiteSparse:GraphBLAS-specific",...

@sneakers-the-rat, please let us know if there is anything we can do (chat, meet, reply to issues, etc.) to help you understand our project and perform the review more effectively.