Erik Verbruggen

Results 71 comments of Erik Verbruggen

> Shouldn't we add the extra period to the code that needs it and not to the variable itself? Done

> Enough to fix this for 2.10? If the cmake invocation of the CI/release-build-thingy is done, then yes.

Merge after #9212 is merged.

Selection should work different: when the tab "focus" is changed, the new tab should be foregrounded immediately

The tab is always shown by default, and removed when none of the servers supports it. I think reverting this would be ok: do not show it by default, but...

I cannot reproduce this anymore. Can you check if this is issue is still there, and if so, give the steps to reproduce it?

> https://stackoverflow.com/questions/71118094/why-is-my-app-icon-bigger-than-the-others-in-the-macos-dock > Looks like apple is not capable of scaling an icon to its idea of a design. > We can either ignore it, follow it on all platforms,...

I think it would be better to either move the `SpacesManager` to the `AccountState` (as it's only used when there is a state), or connect it (directly, or indirectly through...

The `SpacesManager` is used in the cmdline client, so moving its ownership is not an option. Going for #2: connect the slot from the outside when creating an `AccountState`