shrine-rails-example
shrine-rails-example copied to clipboard
erikdahlstrand
Testing
It could be a good idea to provide the tests for this shrine example.
regards,
I agree, that is a good idea, it would give more value to the implementation, I will get working on those.
I decided that adding and maintaining tests for the example app isn't worthwhile. Mostly because I find writing end-to-end tests slighly PITA. Also, since I would have to communicate directly to S3, it would be difficult for me to set the timeouts which won't be too short for slower connections. I described in the README exactly how the app works, that should hopefully be enough.
@janko-m just wanted to comment that having some basic specs would be helpful
The official demo app has an acceptance test, would something like that suffice? (just that we port if over here)
would something like that suffice?
Yes! This is great. Thanks for pointing me toward that