ann-benchmarks icon indicating copy to clipboard operation
ann-benchmarks copied to clipboard

Support for MariaDB database

Open HugoWenTD opened this issue 1 year ago • 8 comments
trafficstars

MariaDB supports Vector now. https://mariadb.com/kb/en/vector-overview/ Add new module for benchmark against MariaDB 11.8 database server.

HugoWenTD avatar Oct 18 '24 17:10 HugoWenTD

Thanks @HugoWenTD. Please make sure to add a test case to the CI as well.

maumueller avatar Oct 21 '24 06:10 maumueller

Are you planning to finish this @HugoWenTD ?

erikbern avatar Mar 17 '25 03:03 erikbern

Are you planning to finish this @HugoWenTD ?

Yes Erik, I'll work on it this week.

HugoWenTD avatar Mar 17 '25 03:03 HugoWenTD

Ok, nice!

erikbern avatar Mar 18 '25 01:03 erikbern

This is failing in CI for some reason, any idea why? https://github.com/erikbern/ann-benchmarks/actions/runs/14016901547/job/39890033550?pr=548

erikbern avatar Apr 03 '25 03:04 erikbern

This is failing in CI for some reason, any idea why? https://github.com/erikbern/ann-benchmarks/actions/runs/14016901547/job/39890033550?pr=548

Weird. Looks it's failing with --batch option. I'll look into it.

ERROR - double free or corruption (!prev)

HugoWenTD avatar Apr 03 '25 05:04 HugoWenTD

This is failing in CI for some reason, any idea why? https://github.com/erikbern/ann-benchmarks/actions/runs/14016901547/job/39890033550?pr=548

I suspect it's related to the ThreadPool and mariadb cursor.

    def batch_query(self, X: numpy.array, n: int) -> None:
        pool = ThreadPool()
        self.res = pool.map(lambda q: self.query(q, n), X)
    def query(self, v, n):
        self._cur.execute(self._sql_search, (self.vector_to_hex(v), n))

        return [id for id, in self._cur.fetchall()]

HugoWenTD avatar Apr 03 '25 05:04 HugoWenTD

Updated the batch_query. It should work now.

HugoWenTD avatar Apr 10 '25 16:04 HugoWenTD